Expand Caching section in README - #423
Merged
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #423 +/- ##
=======================================
Coverage 67.55% 67.55%
=======================================
Files 8 8
Lines 299 299
Branches 5 5
=======================================
Hits 202 202
Misses 97 97 Continue to review full report at Codecov.
|
rafaparadela
approved these changes
Jan 14, 2021
rafaparadela
left a comment
There was a problem hiding this comment.
Thanks for expanding such a great explanation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To address #306 which expressed some confusion on how caching and deduplication works, I've expanded the section to contain an example of sharing the cache between successive computations.
A couple other small changes that are tagging along:
filterKeysin the microsite docs